Re: [PATCH] serial: imx: Use NULL as the last argument of add_preferred_console()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 01, 2013 at 10:24:35PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> 
> Commit f7d2c0bbd (serial: i.MX: evaluate linux,stdout-path property) introduced
> the following sparse warning:
> 
> drivers/tty/serial/imx.c:1916:77: warning: Using plain integer as NULL pointer
> 
> Pass NULL as the last argument of add_preferred_console() instead of zero.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>


Acked-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

Sascha

> ---
>  drivers/tty/serial/imx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 2c13155..9a66dc5 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1913,7 +1913,8 @@ static int serial_imx_probe_dt(struct imx_port *sport,
>  	sport->devdata = of_id->data;
>  
>  	if (of_device_is_stdout_path(np))
> -		add_preferred_console(imx_reg.cons->name, sport->port.line, 0);
> +		add_preferred_console(imx_reg.cons->name, sport->port.line,
> +				      NULL);
>  
>  	return 0;
>  }
> -- 
> 1.8.1.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux