Re: [PATCH V2 00/25] tty: serial: drop uart_port->lock before calling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Peter,

On 19 August 2013 21:01, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote:

> Please review commit 677fe555cbfb188af58cce105f4dae9505e58c31
> 'serial: imx: Fix recursive locking bug' to see if that is actually the
> problem
> you're having with the samsung serial driver.

No, this doesn't seem to be the same issue... The issue here is:

s3c24xx_serial_rx_chars()
-> spin_lock_irqsave(&port->lock, flags);
-> tty_flip_buffer_push()
  -> flush_to_ldisc()
    -> n_tty_receive_buf2()
      -> __receive_buf()
         -> uart_start()
            -> spin_lock_irqsave(&port->lock, flags);

This seems to be a generic enough problem as many drivers are already
doing the right thing. They release lock before calling
tty_flip_buffer_push()..

And that's why my patchset had only 25 patches :)
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux