Re: [PATCH] tilegx: Add tty serial support for TILE-Gx on-chip UART

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 12, 2013 at 02:11:44PM -0400, Chris Metcalf wrote:
> +/*
> + * Enable modem status interrupts.
> + */
> +static void tilegx_enable_ms(struct uart_port *port)
> +{
> +	/* N/A */
> +}
> +
> +/*
> + * Control the transmission of a break signal.
> + */
> +static void tilegx_break_ctl(struct uart_port *port, int break_state)
> +{
> +	/* N/A */
> +}

For most of these "empty" callbacks, you shouldn't have to declare them
at all, and all should work just fine.

Other than that minor nit, at first glance this looks fine to me.

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux