On Sunday 21 of July 2013 21:42:45 Sylwester Nawrocki wrote: > This patch restores serial port operation which has been broken since > commit 60e93575476f90a72146b51283f514da655410a7 > serial: samsung: enable clock before clearing pending interrupts during > init > > That commit only uncovered the real issue which was missing clkdev > entries for the "uart" clocks on S3C2440. It went unnoticed so far > because return value of clk API calls were not being checked at all > in the samsung serial port driver. > > This patch should be backported to at least 3.10 stable kernel, since > the serial port has not been working on s3c2440 since 3.10-rc5. > > Cc: Chander Kashyap <chander.kashyap@xxxxxxxxxx> > Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> > [on S3C2440 SoC based Mini2440 board] > Tested-by: Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> > --- > > There seems to be something wrong with the process, as things are > getting broken late in the -rc cycle. It seems author of the above > mentioned commit didn't test all 6 SoC series that the samsung > serial driver handles. While I can understand they might not have > all required hardware it's a bit irritating that the patch that > in practice caused regression appeared only on linux-serial mailing > list. And it's not evident it was even tried to test it on all > potentially affected platforms. It not clear on what platforms > the patch has been tested. > > My humble suggestion is, _please_ do send patches that affect multiple > Samsung SoCs to linux-samsung@xxxxxxxxxxxxxxx. So there is better > review and test exposure. And we can reduce mess like this happening > in the future. > > Thanks! > Sylwester > --- > arch/arm/mach-s3c24xx/clock-s3c2410.c | 161 > +++++++++++++++++----------- arch/arm/mach-s3c24xx/clock-s3c2440.c > | 3 + > arch/arm/plat-samsung/include/plat/clock.h | 5 + > 3 files changed, 106 insertions(+), 63 deletions(-) Reviewed-by: Tomasz Figa <t.figa@xxxxxxxxxxx> Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
