On Fri, Jun 28, 2013 at 10:17:49AM +0800, Huang Shijie wrote: > We need to set the imx_setUp_ufcr() in our imx_console_setup(), > so we need to enable the clocks, aren't we? Ah, yes, I missed that. But register access only needs ipg clock and per clock still does not need to be enabled here, right? > In the probe's uart_add_one_port(), we will register the console and > call the setup() hook, > so it's ok to disable the clocks in the end of the probe. Look, here is what you do in .probe(). clk_prepare_enable(sport->clk_per); clk_prepare_enable(sport->clk_ipg); ... uart_add_one_port(&imx_reg, &sport->port); ... clk_disable_unprepare(sport->clk_per); clk_disable_unprepare(sport->clk_ipg); Since imx_console_setup() will be called in uart_add_one_port() and clocks are already being taken care of in imx_console_setup(), why do you need all these clock operations here at all? Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
