On 17 June 2013 14:22, Alim Akhtar <alim.akhtar@xxxxxxxxx> wrote: > Hi Chander and Mark > > > On Mon, Jun 17, 2013 at 2:16 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote: >> >> Hi, >> >> > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> > b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> > new file mode 100644 >> > index 0000000..43f0eb8 >> > --- /dev/null >> > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> > @@ -0,0 +1,40 @@ >> > +/* >> > + * SAMSUNG SMDK5420 board device tree source >> > + * >> > + * Copyright (c) 2013 Samsung Electronics Co., Ltd. >> > + * http://www.samsung.com >> > + * >> > + * This program is free software; you can redistribute it and/or modify >> > + * it under the terms of the GNU General Public License version 2 as >> > + * published by the Free Software Foundation. >> > +*/ >> > + >> > +/dts-v1/; >> > +#include "exynos5420.dtsi" >> > + >> > +/ { >> > + model = "Samsung SMDK5420 board based on EXYNOS5420"; >> > + compatible = "samsung,smdk5420", "samsung,exynos5420"; >> > + >> > + memory { >> > + reg = <0x20000000 0x10000000 >> > + 0x30000000 0x10000000 >> > + 0x40000000 0x10000000 >> > + 0x50000000 0x10000000 >> > + 0x60000000 0x10000000 >> > + 0x70000000 0x10000000 >> > + 0x80000000 0x10000000 >> > + 0x90000000 0x10000000>; >> > + }; >> >> As splitting these into 256MB banks is a workaround for an implementation >> issue, there should at least be a comment to that effect. >> >> It would be far nicer if this were described as one bank and the kernel >> could >> split it up as necessary when using sparsemem. >> > Yes, I thing this is not needed at all, the bootloader should be setting > this for us. > Either remove this completly or just add as single bank of memory, like > starting address and the size. I will convert it to single bank and resend. > >> Thanks, >> Mark. >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-samsung-soc" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > Regards, > Alim -- with warm regards, Chander Kashyap -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
