Hi Huang, On Sat, Jun 8, 2013 at 5:04 AM, Huang Shijie <b32955@xxxxxxxxxxxxx> wrote: > + if (!uart_console(port)) { > + retval = clk_prepare_enable(sport->clk_per); > + if (retval) > + goto error_out1; > + retval = clk_prepare_enable(sport->clk_ipg); > + if (retval) > + goto error_out1; Here you should not jump to "error_out1". You should jump to a different label and disable the sport->clk_per clock. This was also wrong in your previous patch. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html