>-----Original Message----- >From: Estevam Fabio-R49496 >Sent: Wednesday, June 05, 2013 9:47 AM >To: Lu Jingchang-B35083; gregkh@xxxxxxxxxxxxxxxxxxx >Cc: shawn.guo@xxxxxxxxxx; kernel@xxxxxxxxxxxxxx; linux- >serial@xxxxxxxxxxxxxxx; festevam@xxxxxxxxx >Subject: RE: [PATCH v2 2/2] serial: imx: Allow module build > >Hi Lu, > >[Sorry for top-posting. I only have email access from browser now]. > >Building as module does work for me. > >Please do a 'make clean' and then try again. > > [Lu Jingchang-B35083] With make arch=ARM clean, I still meet the same fail problem. Does the driver support console when built as module? If it does, I see that "uart_console_device" referenced by imx.c is not exported with EXPORT_SYMBOL in serial core. >From the patch, I think the drive support console when built as module, doesn't it? But explanation from Arnd Bergmann [arnd@xxxxxxxx] yesterday is: "All serial port drivers do this. IIRC the reason is that the console has to be started from console_initcall(), which is not available in modules." It seems serial driver module mode doesn't support console support, do I misunderstand? Thanks! Best regards, Jingchang ________________________________________ >From: Lu Jingchang-B35083 >Sent: Tuesday, June 04, 2013 8:36 PM >To: Estevam Fabio-R49496; gregkh@xxxxxxxxxxxxxxxxxxx >Cc: shawn.guo@xxxxxxxxxx; kernel@xxxxxxxxxxxxxx; linux- >serial@xxxxxxxxxxxxxxx >Subject: RE: [PATCH v2 2/2] serial: imx: Allow module build > >>-----Original Message----- >>From: Estevam Fabio-R49496 >>Sent: Wednesday, June 05, 2013 1:09 AM >>To: gregkh@xxxxxxxxxxxxxxxxxxx >>Cc: shawn.guo@xxxxxxxxxx; Lu Jingchang-B35083; kernel@xxxxxxxxxxxxxx; >>linux-serial@xxxxxxxxxxxxxxx; Estevam Fabio-R49496 >>Subject: [PATCH v2 2/2] serial: imx: Allow module build >> >>There is no need to only allow the serial driver to be built-in. >> >>Allow the imx serial driver to be build as a module. >> >>Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> >>--- >>Changes since v1: >>- None >> drivers/tty/serial/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig >>index a9ae1cd..28cffda 100644 >>--- a/drivers/tty/serial/Kconfig >>+++ b/drivers/tty/serial/Kconfig >>@@ -551,7 +551,7 @@ config BFIN_UART3_CTSRTS >> Enable hardware flow control in the driver. >> >> config SERIAL_IMX >>- bool "IMX serial port support" >>+ tristate "IMX serial port support" >> depends on ARCH_MXC >> select SERIAL_CORE >> select SERIAL_CORE_CONSOLE >>-- >[Lu Jingchang-B35083] >With the two patches, when configure the imx serial driver as a module, I >fail to build it with following error message: > >ERROR: "uart_console_device" [drivers/tty/serial/imx.ko] undefined! >make[1]: *** [__modpost] Error 1 > >Best regards, >Jingchang -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
