Re: [PATCH v2] serial: sccnxp: Improve verify_port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 14, 2013 at 08:30:47PM +0400, Alexander Shiyan wrote:
> > On Tue, May 14, 2013 at 07:59:11PM +0400, Alexander Shiyan wrote:
> > > The patch improves verify_port procedure by comparing the type of
> > > port and IRQ numbers simultaneously. This can be important in the
> > > case of multiple drivers SCCNXP in the system that are different IRQs.
> > 
> > So this fixes a bug?  Really?
> 
> Only in theory.

How?  It really doesn't look like you are doing anything here, except
rearranging the logic to look different, but yet do the same thing.

So again, why are you doing this?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux