Hi, On Fri, Mar 22, 2013 at 11:24:21AM +0200, Heikki Krogerus wrote: > On Fri, Mar 22, 2013 at 04:16:48PM +0800, Ley Foon Tan wrote: > > Besides the fifo size, we need to have hardware flow control setting > > from device tree as well. > > This is a bit problematic. We can set the uart_8250_port.capabilities > flag UART_CAP_AFE based on "hw-flow-control" property, but then the > properties from the type will not be used, just like in case of > fifosize. We would need to know all the flags of the type that are > normally taken from the uart_config[] array. > > The UART_CAP_FIFO can be set by checking if we have set the > port.fifosize or not, so if the bellow is acceptable then I can make a > patch. There is no risk of overriding the capabilities for the > existing uarts, as we only touch the uart_8250_port.capabilities if > the new properties are used. So is it OK? I'll resend these two patches and add the support for hardware flow control. -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html