On Wed, Feb 13, 2013 at 04:34:36PM +0200, Felipe Balbi wrote: > On Wed, Feb 13, 2013 at 03:28:51PM +0100, Johan Hovold wrote: > > Make sure serial-driver dtr_rts is called with disc_mutex held after > > checking the disconnected flag. > > > > Due to a bug in the tty layer, dtr_rts may get called after a device has > > why don't you fix the bug in the tty layer instead ? I'm workin on it. ;) As I mentioned earlier I'll send a follow up mail with some more details on the tty issue and some RFC patches which would actually fix the immediate issue as well. There is nothing wrong with checking the disconnected flag either way. In fact, it could be considered an optimisation as it will be set once the physical device is gone which is some time before the hangup is complete and the tty device unregistered. We already use the flag to prevent further opens after a disconnect. /Johan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
