Dear Claudio, I am not quite happy with your msleep patch because a) It doesn't assert RTS during the sleep, so we don't have the intended effect b) It will do the gaps before / after each character, not frame c) It will raise a "BUG scheduling while atomic". As far as I see, it is not allowed to do sleeps inside of the tasklet code The crisv10 driver does this things more the way I have expected (although it doesn't implement delay_rts_after_send). But a direct port of this code seams not to be possible because - this driver still is build on the tty interface while the newer driver use the uart_port interface from serial_core - the crisv10 driver uses some architecture specific fast_timer code I will continue to work on this issues and hopefully I can provide you a patch in a few days. The TTGR patch looks good, but why haven't you used my dev_get_drvdata(dev) code? Regards, Guido On Mon, Feb 11, 2013 at 4:54 PM, <claudio@xxxxxxxxxxxxxxx> wrote: > Dear Guido. > > I agree about splitting the patch. Therefore, I've created the following patchset which > > - Adds the unit of measure (i.e., milliseconds) in the documentation > serial-rs485.txt (it is already available in the header file). > > - Sets RS485 delays using msleep (as in the cris driver) rather than using > TTGR. > > - Adds an entry in sys/ to get/set the TTGR register for this specific driver. > > Have you tested the msleep part ? > > Best regards, > > Claudio -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
