On Thu, 2013-02-07 at 15:51 +0100, Jiri Slaby wrote: > On 02/05/2013 09:20 PM, Peter Hurley wrote: > > Factor the packet mode status change from n_tty_flush_buffer > > for use by follow-on patch. > > > > Signed-off-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> > > --- > > drivers/tty/n_tty.c | 24 ++++++++++++++---------- > > 1 file changed, 14 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c > > index bf6958b..7194a33 100644 > > --- a/drivers/tty/n_tty.c > > +++ b/drivers/tty/n_tty.c > > @@ -237,6 +237,18 @@ static void reset_buffer_flags(struct tty_struct *tty) > > n_tty_set_room(tty); > > } > > > > +static void packet_mode_flush(struct tty_struct *tty) > > I prefer naming functions according the name space they live in. In this > case n_tty_flush_packet_mode would be much better. Other than that this > one looks good. Ok, I'll do that. (FWIW, the reason I used that naming was the 'n_tty style' appears to be un-prefixed file-scope functions and prefixed global-scope functions.) -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
