On 02/06/2013 04:55 PM, Peter Hurley wrote: > --- a/drivers/pps/clients/pps-ldisc.c > +++ b/drivers/pps/clients/pps-ldisc.c > @@ -25,17 +25,47 @@ ... > +struct pps_data { > + struct pps_device *pps; > + struct tty_struct *tty; > + struct list_head link; > +}; > + > +DEFINE_SPINLOCK(pps_lock); > +static LIST_HEAD(pps_list); All 4 look fine, nice cleanup. Except the lock above should be static too. thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html