Re: [PATCH v2] ARM: PL011: Add support for Rx DMA buffer polling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 23, 2013 at 02:07:57PM +0900, Chanho Min wrote:
> On Tue, Jan 22, 2013 at 10:18 PM, Linus Walleij
> <linus.walleij@xxxxxxxxxx> wrote:
> >> - If poll timer is activated, We use consistent DMA mappings to avoid from
> >>   the frequent cache operation of the timer function. sg->coherency is used
> >>   to check if buffer is coherent.
> >
> > Hm. We can begin like this but maybe we should later patch it to
> > make this the default unless it has performance impacts on our
> > systems.
> Good, I really hope to make this the default.
> We expect it has no impact to system even if no polling use.
> 
> > Maybe this is a good opportunity to add some kerneldoc above
> > this struct so as to help platform implementers. It will invariably
> > be reused by Device Tree binding authors later on...
> Agree, but, frankly I need help about what I didn't modify.
> So We will leave this work for the next submit.

So, should this patch be applied?  Can I get an ack from someone who
knows this driver/platform please?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux