Re: [PATCH] tty: serial/crisv10.c: remove unnecessary null pointer check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 16, 2013 at 11:30:44PM +0100, Cong Ding wrote:
> The pointer tty is dereferened in line 3135, so it is not necessary to check
> null again in line 3140.

I don't know if we actually need to check the parameter tty from being null,
but when checking the rest of the file, most other functions don't check it.

In any case, gcc is quite likely to remove that check due to the
earlier dereference, so removing it is probably acceptable.

> Signed-off-by: Cong Ding <dinggnu@xxxxxxxxx>

Thanks, I'll take it in the CRIS tree.

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux