On Mon, Jan 14, 2013 at 06:12:34PM +1000, Kevin Nguyen wrote: > Hi Greg, > > The RS485 mode can be switched on/off from userspace by using the flag > SER_RS485_ENABLED, therefore I've removed those #ifdefs in the patch. Much better, thanks. Can you also remove the debugging printk() messages you added? Or, convert them to dev_dbg() calls instead? If you run your patch through the scripts/checkpatch.pl tool, it should tell you things like this. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
