Hello Alan Cox: can you have time to give a glance for it ? I send it according to the MAINTAINER file, if I send to an incorrect member, please tell me. thanks. gchen 于 2012年12月26日 18:06, Chen Gang 写道: > > before goto out5, soft, control, serial are all assigned to idd > after finish call ioc4_serial_remove_one, all resources are released > we need return instead of go on, or double free > > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> > --- > drivers/tty/serial/ioc4_serial.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/ioc4_serial.c b/drivers/tty/serial/ioc4_serial.c > index 3e7da10..c4e30b8 100644 > --- a/drivers/tty/serial/ioc4_serial.c > +++ b/drivers/tty/serial/ioc4_serial.c > @@ -2883,6 +2883,7 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd) > /* error exits that give back resources */ > out5: > ioc4_serial_remove_one(idd); > + return ret; > out4: > kfree(soft); > out3: > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
