Re: [PATCH V2] serial: tegra: add serial driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/17/2012 11:59 PM, Laxman Dewangan wrote:
> Nvidia's Tegra has multiple uart controller which supports:

A few nits:

That should be NVIDIA.

>  .../devicetree/bindings/serial/serial-tegra.txt    |   24 +

I strongly object to this name; I believe nvidia,tegra20-hsuart.txt is
correct.

> +NVIDIA Tegra20/Tegra30 high speed (dma based) UART controller driver.

DMA, UART (below), ... should be all capitals.

The binding looks reasonable to me. The few parts of the code I looked
at look OK.

> diff --git a/include/linux/platform_data/serial-tegra.h b/include/linux/platform_data/serial-tegra.h
> +#endif /* _SERIAL_TEGRA_H_ */
> +

There's a blank line at the end of the file.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux