On Wed, Nov 28, 2012 at 11:05:08AM +0200, Alexey Pelykh wrote: > Original table in OMAP TRM named "UART Mode Baud Rates, Divisor > Values, and Error Rates" determines modes not for all common baud > rates. E.g. for 1000000 baud rate mode should be 16x, but according to > that table it's determined as 13x. According to current implementation > of mode > divisor selection, after requesting 1000000 baudrate from driver, > later one will configure chip to use MODE13 divisor. Assuming 48Mhz as > common UART clock speed, MODE13 divisor will effectively give 1230769 > baudrate, what is quite far from desired 1000000 baudrate. While with > MODE16 divisor, chip will produce exact 1000000 baudrate. > > In old driver that served UART devices (8250.c and serial_core.c) this > divisor could have been configured by user-space program, but in > omap_serial.c driver implementation this ability was not implemented > (afaik, by design) thus disallowing proper usage of MODE16-compatible > baudrates. > > Changes: I've fixed styling errors using ./scripts/checkpatch.pl > > Signed-off-by: Alexey Pelykh <alexey.pelykh@xxxxxxxxx> > > The following changes since commit 77b67063bb6bce6d475e910d3b886a606d0d91f7: Again, I will not take a pull request, why do you keep on sending this? Please just send your patch through mail, in a format that I can apply it in (as described in Documentation/SubmittingPatches). thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html