Hi, Alan, Thank you very much! Jun -----Original Message----- From: Alan Cox [mailto:alan@xxxxxxxxxxxxxxxxxxx] Sent: Monday, November 05, 2012 7:43 PM To: Chen, Jun D Cc: alan@xxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; Gorby, Russ; Liu, Chuansheng; Bi, Chao Subject: Re: [PATCH] serial: ifx6x60: Add module parameters to manage the modem status through sysfs. On Mon, 5 Nov 2012 08:26:08 +0000 "Chen, Jun D" <jun.d.chen@xxxxxxxxx> wrote: > Hi,Alan > Thank your reply and advice. > > + if (reset_request == IFX_COLD_RESET_REQ) { > > + /* Need to add these action for modem cold reset: > > + * - Set the RESET_BB_N to low (better SIM protection) > > + * - Set the EXT1P35VREN field to low during 20ms (V1P35CNT_W register) > > + * - set the EXT1P35VREN field to high during 10ms (V1P35CNT_W register) > > + */ > I want to submit one finished version, but these code need to call the > intel_scu_ipc_readv and intel_scu_ipc_writev function defined in the file <asm/intel_scu_ipc.h> But this module seem not to be maked. Now I add one macro to disable these functions. I will send the new patch to you and would you like to give more suggestion about this issue. You probably need your Kconfig entry to have depends on X86_INTEL_MID && INTEL_SCU_IPC so that it can only be compiled when the feature is present. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html