> + if (reset_request == IFX_COLD_RESET_REQ) {
> + /* Need to add these action for modem cold reset:
> + * - Set the RESET_BB_N to low (better SIM protection)
> + * - Set the EXT1P35VREN field to low during 20ms (V1P35CNT_W register)
> + * - set the EXT1P35VREN field to high during 10ms (V1P35CNT_W register)
> + */
You seem to have submitted an unfinished version ?
Also can you explain the locking on your new reset_ongoing variable and
hangup_reasons variable ? What stops the sysfs code being run in parallel
with the other bits or even twice at once.
Looking at it I get the impression that
a) the variable should be in the device structure not a static global
b) it is write only which seems pointless
c) you probably want a mutex around the actual reset processes so that
reset is single threaded in each case.
d) that mutex probably belongs in the device structure
The hangup reasons in this patch also appears to be write only ?
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
