On 11/05/2012 05:22 AM, Michal Simek wrote: > 2012/10/29 Josh Cartwright <josh.cartwright@xxxxxx>: >> Suggested cleanup by Arnd Bergmann. Move the ttc timer.c code to >> drivers/clocksource, and out of the mach-zynq directory. >> >> The common.h (which only held the timer declaration) was renamed to >> xilinx_ttc.h and moved into include/linux. >> >> Signed-off-by: Josh Cartwright <josh.cartwright@xxxxxx> >> Cc: Arnd Bergmann <arnd@xxxxxxxx> >> --- >> arch/arm/mach-zynq/Makefile | 2 +- >> arch/arm/mach-zynq/common.c | 2 +- >> drivers/clocksource/Makefile | 1 + >> arch/arm/mach-zynq/timer.c => drivers/clocksource/xilinx_ttc.c | 1 - >> arch/arm/mach-zynq/common.h => include/linux/xilinx_ttc.h | 4 ++-- >> 5 files changed, 5 insertions(+), 5 deletions(-) >> rename arch/arm/mach-zynq/timer.c => drivers/clocksource/xilinx_ttc.c (99%) >> rename arch/arm/mach-zynq/common.h => include/linux/xilinx_ttc.h (91%) > > Not going to apply this patch till there is clean way how to move all > drivers there. > Especially I don't like to add xilinx_ttc.h to include/linux folder. > A cleaner way is how we are doing irqchips [1]. This needs a single function (or one each for clksrc and clkevt) that has a DT match list of all known timers and calls their init function. It should be a bit simpler than irqchips init function because you don't need to worry about hierarchy init ordering. That doesn't solve non-DT though and if there are any extra functions like we have with irqchips, you still need the header in include/linux. Rob [1] http://www.spinics.net/lists/arm-kernel/msg203687.html -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
