On Tue, Sep 18, 2012 at 04:14:59PM +0800, Richard Zhao wrote: > platform_get_drvdata always retrun a valid value after probe succeed. > > It also fixed smatch warnings: > drivers/tty/serial/imx.c:1376 serial_imx_suspend() warn: variable dereferenced before check 'sport' (see line 1372) > drivers/tty/serial/imx.c:1392 serial_imx_resume() warn: variable dereferenced before check 'sport' (see line 1388) > > Signed-off-by: Richard Zhao <richard.zhao@xxxxxxxxxxxxx> Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > --- > drivers/tty/serial/imx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index 49f664f..efeb8be 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -1373,8 +1373,7 @@ static int serial_imx_suspend(struct platform_device *dev, pm_message_t state) > val |= UCR3_AWAKEN; > writel(val, sport->port.membase + UCR3); > > - if (sport) > - uart_suspend_port(&imx_reg, &sport->port); > + uart_suspend_port(&imx_reg, &sport->port); > > return 0; > } > @@ -1389,8 +1388,7 @@ static int serial_imx_resume(struct platform_device *dev) > val &= ~UCR3_AWAKEN; > writel(val, sport->port.membase + UCR3); > > - if (sport) > - uart_resume_port(&imx_reg, &sport->port); > + uart_resume_port(&imx_reg, &sport->port); > > return 0; > } > -- > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
