On Tue, Sep 18, 2012 at 04:14:58PM +0800, Richard Zhao wrote: > Signed-off-by: Richard Zhao <richard.zhao@xxxxxxxxxxxxx> I think it's worth to have a sensible commit log explaining why it has not trigger any issue. It happens to work without problem because "struct uart_port port" is the first member of "struct imx_port". Otherwise, Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > --- > drivers/tty/serial/imx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index 5952b25..49f664f 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -1540,7 +1540,7 @@ static int serial_imx_probe(struct platform_device *pdev) > ret = uart_add_one_port(&imx_reg, &sport->port); > if (ret) > goto deinit; > - platform_set_drvdata(pdev, &sport->port); > + platform_set_drvdata(pdev, sport); > > return 0; > deinit: > -- > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
