On 12-06-27 07:52 AM, Alan Cox wrote: > On Tue, 26 Jun 2012 15:54:29 -0400 > Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > >> We've are dropping the support for the EOL SBC8560, so we can >> also delete this variant of the Alpha quirk support. >> >> Cc: Alan Cox <alan@xxxxxxxxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> Cc: linux-serial@xxxxxxxxxxxxxxx >> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> >> --- >> drivers/tty/serial/8250/8250.h | 7 ------- >> 1 files changed, 0 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h >> index f9719d1..ffd1e6e 100644 >> --- a/drivers/tty/serial/8250/8250.h >> +++ b/drivers/tty/serial/8250/8250.h >> @@ -119,13 +119,6 @@ static inline void serial_dl_write(struct uart_8250_port *up, int value) >> * is cleared, the machine locks up with endless interrupts. >> */ >> #define ALPHA_KLUDGE_MCR (UART_MCR_OUT2 | UART_MCR_OUT1) >> -#elif defined(CONFIG_SBC8560) >> -/* >> - * WindRiver did something similarly broken on their SBC8560 board. The >> - * UART tristates its IRQ output while OUT2 is clear, but they pulled >> - * the interrupt line _up_ instead of down, so if we register the IRQ >> - * while the UART is in that state, we die in an IRQ storm. */ >> -#define ALPHA_KLUDGE_MCR (UART_MCR_OUT2) >> #else >> #define ALPHA_KLUDGE_MCR 0 >> #endif > > Would you mind removing all of the crap from this if its going (eg > 8250.c) not just the header so it gets missed ? Kill the symbol entirely ? I will, once Alpha is removed from the tree. At the moment, it still uses it. Paul. -- > > Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html