On Fri, Jun 22, 2012 at 04:43:51PM +0100, Alan Cox wrote: > @@ -69,7 +69,6 @@ struct uart_port; > struct uart_8250_port; > > int serial8250_register_8250_port(struct uart_8250_port *); > -int serial8250_register_port(struct uart_port *); There are still in-kernel callers of this function, so I don't think it's safe to remove just yet, otherwise the build will break: drivers/char/mwave/mwavedd.c: return serial8250_register_port(&uart); drivers/misc/ibmasm/uart.c: sp->serial_line = serial8250_register_port(&uport); drivers/net/ethernet/sgi/ioc3-eth.c: serial8250_register_port(&port); drivers/tty/serial/of_serial.c: ret = serial8250_register_port(&port); I'm stopping here on this series, I've only applied the one that added the comment, that seems to be the only one that compiled properly :( Care to redo these please? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
