On Sun, Jun 17, 2012 at 10:44 AM, Linus Walleij <linus.walleij@xxxxxxxxxxxxxx> wrote: > uap->pinctrl = devm_pinctrl_get(&dev->dev); > if (IS_ERR(uap->pinctrl)) { > ret = PTR_ERR(uap->pinctrl); > - goto unmap; > + goto out; > } > uap->pins_default = pinctrl_lookup_state(uap->pinctrl, > PINCTRL_STATE_DEFAULT); > @@ -1915,7 +1917,7 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id) > uap->clk = clk_get(&dev->dev, NULL); Maybe you can use devm_clk_get here too. ��.n��������+%������w��{.n�����{��ǫ����{ay�ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��