On Wed, May 23, 2012 at 09:18:46PM +0200, Linus Walleij wrote: > From: Linus Walleij <linus.walleij@xxxxxxxxxx> > > We had a boot regression in Ux500 in the merge window because > two orthogonal pin control schemes for the PL011 were merged > at the same time: > > - One using the .init() and .exit() hooks into the platform > for Ux500 putting the pins into default vs sleep state > respectively as the port was started/stopped. > commit a09806607fd20bed2f8c41fe22793386790a14aa > "ARM: ux500: switch to using pinctrl for uart0" > > - One hogging the default setting at PL011 probe() > commit 258e055111d3cde2607e0d04eb91da2f7a59b591 > "serial: amba-pl011: adopt pinctrl support" > > To get a solution that works for both let's scrap the stuff > in the platform callbacks, instead have the driver itself > select default and sleep states when the port is > started/stopped. Hopefully this works for all clients. > Platform callbacks are bad for device tree migration anyway, > so this rids us of another problem in Ux500. > > Cc: linux-serial@xxxxxxxxxxxxxxx > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Shawn Guo <shawn.guo@xxxxxxxxxx> > Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> > Reported-by: Lee Jones <lee.jones@xxxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> On imx28: Tested-by: Shawn Guo <shawn.guo@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
