I agree that losing bytes in the software layer wouldn't happen under normal circumstances, but it is still important to know when it happens. My understanding was that the overrun field in the port's icount was for logging hardware overruns, while the buf_overrun field should be used for software overruns. If this is not the case then is there another method for determining when the software layer is losing bytes? Thanks, Corbin On Tue, May 15, 2012 at 10:58 AM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, May 15, 2012 at 04:53:39PM +0100, Alan Cox wrote: > > On Fri, 4 May 2012 12:35:10 -0500 > > Corbin Atkinson <corbinat@xxxxxxxxx> wrote: > > > > > Currently, serial drivers don't report buffer overruns. When a buffer > > > overrun > > > occurs, tty_insert_flip_char returns 0, and no attempt is made to > > > insert that > > > same character again (i.e. it is lost). This patch reports buffer > > > overruns via > > > the buf_overrun field in the port's icount structure. > > > > I think this is mostly a misunderstanding - it's always been interpreted > > as logging hardware reported overrruns. The case of the software layer > > losing bytes is a "doesn't happen in normal circumstances" situation. At > > least it should be. > > Hm, I applied this already, should I revert it? > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
