On Wednesday 02 May 2012, Greg KH wrote: > > > + > > > +config SERIAL_8250_EM > > > + tristate "Support for Emma Mobile intergrated serial port" > > > + depends on SERIAL_8250 > > > > Should we depend on arch=ARM or something similar? Even if the > > driver is written to be arch independent, if the Emma itself is > > physically tied to ARM platforms, we probably don't need to be > > building it for sparc allyesconfig etc. > > Yeah, it doesn't build on x86-64, I get the following build problems: > ERROR: "clk_get_rate" [drivers/tty/serial/8250/8250_em.ko] undefined! > ERROR: "clk_enable" [drivers/tty/serial/8250/8250_em.ko] undefined! > ERROR: "clk_get" [drivers/tty/serial/8250/8250_em.ko] undefined! > ERROR: "clk_put" [drivers/tty/serial/8250/8250_em.ko] undefined! > ERROR: "clk_disable" [drivers/tty/serial/8250/8250_em.ko] undefined! > > So it should depend on some arch that has clk at the least. > > Magnus, care to redo just this one patch that fixes this up? I've > applied the first 5 already. I think it's best to make it depend on HAVE_CLK, but depending on ARM && HAVE_CLK is also fine with me. I would not like to have it depend on EMMA specifically though because I want to increase built coverage. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
