On Fri, Apr 13, 2012 at 4:11 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> Can someone tell me how this works with the current omap-serial driver
> please? It looks to me like this has been broken when DMA support was
> added to the driver.
Yes x-char transmission in dma case is broken will post a patch to fix this.
>
> Moreover, please look at the probe function error paths. They seem to
> be lacking any kind of realistic cleanup, so are a potential memory leak.
I thought this is fixed in 3.4-rc3 with this commit:
commit 388bc26226807fbcf4c626b81bb17a2e74aa4b1b
Author: Shubhrajyoti D <shubhrajyoti@xxxxxx>
Date: Wed Mar 21 17:22:22 2012 +0530
omap-serial: Fix the error handling in the omap_serial probe
>
> Then there's the issue of fiddling with the xmit buffer so that it's
> using coherent memory in the startup and shutdown functions (why? when
> other serial drivers cope just fine without doing this). If we want to
> use DMA coherent memory there, there should be a clean way to do this,
> rather than going behind the upper layers.
Okay I will have a look into this.
--
Thanks,
Govindraj.R
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
