On Mon, Apr 9, 2012 at 11:49 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Monday 09 April 2012, Dan Williams wrote: >> Benign conversion of of_serial.c to offer the option of 'setup' quirks >> similar to how 8250_pci.c houses the pci-serial-device quirks. >> >> A setup quirk allows custom uart_port ops to specified in the >> of_serial_info data fed to each serial of_device_id. >> >> Tegra's 'break' quirk is the target consumer. >> >> Cc: Colin Cross <ccross@xxxxxxxxxxx> >> Cc: Olof Johansson <olof@xxxxxxxxx> >> Cc: Stephen Warren <swarren@xxxxxxxxxx> >> Cc: Arnd Bergmann <arnd@xxxxxxxx> >> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx> >> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> >> --- >> drivers/tty/serial/of_serial.c | 68 ++++++++++++++++++++++++++++------------ >> 1 files changed, 47 insertions(+), 21 deletions(-) > > I don't think this is a good idea. Aside from the bug that you introduce > (you can no longer have multiple ports of the same type because of overwrite > the static info->line number), ah, yes, good catch. > it seems an unnecessary complication. > Either just add the quirk to the of_serial file based on the compatible value, > or do a trivial new driver that has a subset of the existing one you need, > plus the quirk. ok. The open question was where to house tegra_serial_handle_break, I'd just as soon keep it all in of_serial.c and maintain the temporary exports for use in the to-be-removed board files in arch/arm/mach-tegra. -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
