Re: [PATCH] serial: PL011: move interrupt clearing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 29, 2012 at 5:33 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Mar 29, 2012 at 02:49:37PM -0600, Grant Likely wrote:
>> On Wed, Mar 21, 2012 at 1:15 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> > Commit 360f748b204275229f8398cb2f9f53955db1503b
>> > "serial: PL011: clear pending interrupts"
>> > attempts to clear interrupts by writing to a
>> > yet-unassigned memory address. This fixes the issue.
>> >
>> > The breaking patch is marked for stable so should be
>> > carried along with the other patch.
>> >
>> > Cc: Shreshtha Kumar Sahu <shreshthakumar.sahu@xxxxxxxxxxxxxx>
>> > Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
>> > Cc: stable <stable@xxxxxxxxxxxxxxx>
>> > Reported-by: Viresh Kumar <viresh.kumar@xxxxxx>
>> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>
>> Ugh; the original patch is obviously broken.  How did it get applied
>> without testing?
>>
>> Greg, can you get this out to Linus ASAP please?  I have one comment
>> below, but I don't think it should block merging this patch.
>>
>> Tested-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
>
> Thanks, I'll get it to him after 3.4-rc1 is out, in a few days, along
> with other tty fixes being queued up.

Hi Greg,

Just wanted to check this didn't fall through the cracks, as I don't
see it in your tty-next or tty-linus branches.

The original bad commit causes Silent Boot Death on qemu ARM
versatile, which is kind of nasty.  It pretty much forces a bisection,
which I did, which then led me here.

Thanks,
Paul.
--

>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux