On Fri, 9 Dec 2011 18:07:14 +0100 Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote: > From: Matthias Fuchs <mfuchs@xxxxxxxx> > > Some Exar UARTs support an auto rs485 mode. In this mode > the UART's RTS# pin is activated during transmitting and > can be used to enable a rs485 line driver. This has nothing > to do with attempts to do this by manually asserting/ > deasserting handshake lines in software. Please split this out so that the ioctl handler calls a pair of port-> methods or errors if NULL. That'll future proof it and keep chip specific stuff out of the direct paths. Other than that I'm fine with it. Functionality, locking etc. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html