On Thu, 8 Dec 2011, Benjamin Herrenschmidt wrote: > On Thu, 2011-12-08 at 15:20 +1100, Benjamin Herrenschmidt wrote: > > > So basic operations seem to work, I've applied the patch to > > powerpc-next. Then I guess Geert should not push this for 3.3 -- or does it make no difference? > > However, the internal modem on my Pismo powerbook doesn't appear to > > survive suspend/resume. I'll dig into that and merge a fixup patch > > asap. > > BTW. I applied anyway because suspend/resume was already broken (you > spotted that we don't clear the suspended flag for example). > > Fixing the flag alone helps a bit. We can't use the modem if we > suspend/resume with the open port, If the SCC IRQ counters change across suspend/resume, perhaps the modem itself is not powering up... > but closing and re-opening works. Maybe the modem wants a transition on DTR or similar, but it hasn't had time to initialise when that happens during SCC resumption. If so, calling pmz_shutdown() then pmz_startup() from the tail of pmz_resume() without delay should probably fail to revive it... > > Lockdep also picked-up a A->B B->A between the port mutex and the pmz > irq mutex on suspend. > > I'll try to fix all these, and will let you know (I may not have time > today). Thanks. Finn > > Cheers, > Ben. > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-m68k" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
