On Wed, 26 Oct 2011, Domenico Andreoli wrote: > > > > The one in 8250_pci.c is trivial to fix, the atmel_serial one isn't as > > > > easy, but I'm sure you can figure it out :) If you want me to do the > > > > merge for it, I'll be glad to do so, just let me know. > > > > > > So I figured it out, but please double-check, especially since it > > > seems to be some arm-only driver that I can't even compile-test my > > > resolution. > > > > I think it looks correct, but yeah, as I can't build it either, it's > > tough to tell. > > > > Nicolas, can you verify that Linus's merge was done correctly? If not, > > can you send a patch? It is commit > > efb8d21b2c6db3497655cc6a033ae8a9883e4063 in Linus's tree right now. > > tryed to build efb8d21 with at91cap9adk_defconfig + DT + 8250 but it fails: > > drivers/tty/serial/atmel_serial.c: In function 'atmel_serial_probe': > drivers/tty/serial/atmel_serial.c:1788:3: error: implicit declaration of function 'of_alias_get_id' [-Werror=implicit-function-declaration] > drivers/tty/serial/atmel_serial.c: At top level: > drivers/tty/serial/atmel_serial.c:1893:3: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration] > drivers/tty/serial/atmel_serial.c:1893:3: error: initializer element is not constant > drivers/tty/serial/atmel_serial.c:1893:3: error: (near initialization for 'atmel_serial_driver.driver.of_match_table') > cc1: some warnings being treated as errors > > there is not mention of such (new) of_match_ptr macro anywhere in Linus' tree. Yes, it's depending on this one, which I believe is queued in Grant's tree but not yet merged: commit 3a1e362e3f3cd571b3974b8d44b8e358ec7a098c Author: Ben Dooks <ben-linux@xxxxxxxxx> Date: Wed Aug 3 10:11:42 2011 +0100 OF: Add of_match_ptr() macro Add a macro of_match_ptr() that allows the .of_match_table entry in the driver structures to be assigned without having an #ifdef xxx NULL for the case that OF is not enabled Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx> Signed-off-by: Grant Likely <grant.likely@xxxxxxxxxxxx> -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
