On Wed, Oct 26, 2011 at 03:34:38PM +0200, Greg KH wrote: > On Wed, Oct 26, 2011 at 03:18:21PM +0200, Linus Torvalds wrote: > > On Wed, Oct 26, 2011 at 1:42 PM, Greg KH <gregkh@xxxxxxx> wrote: > > > > > > The one in 8250_pci.c is trivial to fix, the atmel_serial one isn't as > > > easy, but I'm sure you can figure it out :) If you want me to do the > > > merge for it, I'll be glad to do so, just let me know. > > > > So I figured it out, but please double-check, especially since it > > seems to be some arm-only driver that I can't even compile-test my > > resolution. > > I think it looks correct, but yeah, as I can't build it either, it's > tough to tell. > > Nicolas, can you verify that Linus's merge was done correctly? If not, > can you send a patch? It is commit > efb8d21b2c6db3497655cc6a033ae8a9883e4063 in Linus's tree right now. tryed to build efb8d21 with at91cap9adk_defconfig + DT + 8250 but it fails: drivers/tty/serial/atmel_serial.c: In function 'atmel_serial_probe': drivers/tty/serial/atmel_serial.c:1788:3: error: implicit declaration of function 'of_alias_get_id' [-Werror=implicit-function-declaration] drivers/tty/serial/atmel_serial.c: At top level: drivers/tty/serial/atmel_serial.c:1893:3: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration] drivers/tty/serial/atmel_serial.c:1893:3: error: initializer element is not constant drivers/tty/serial/atmel_serial.c:1893:3: error: (near initialization for 'atmel_serial_driver.driver.of_match_table') cc1: some warnings being treated as errors there is not mention of such (new) of_match_ptr macro anywhere in Linus' tree. Regards, Domenico -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
