On Mon, Jul 04, 2011 at 10:19:25AM +0800, Shawn Guo wrote:
> > > @@ -689,7 +728,7 @@ static int imx_startup(struct uart_port *port)
> > > }
> > > }
> > >
> > > - if (!cpu_is_mx1()) {
> > > + if (IS_IMX2_UART()) {
> >
> > The logic is getting reversed here, is this really what you want to
> > do? I would think you'd want to preserve the !IS_IMX1_UART() logic.
> >
> Maybe not. I actually made a small improvement here. The body of
> the 'if' is really IMX2 specific code, so it makes more sense to use
> IS_IMX2_UART() than !IS_IMX1_UART().
Okay, it would probably be worth mentioning this change in the commit text.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
