Hi Greg > Because if the PCH driver is not available you want to bind > it to the 8250 driver, which also works with it but less efficiently. > > The giant if probably should be a pci match table however Which opinions should I select ? Though Alan's comment has a point, IMHO, in probe processing, the efficiently is not so important. Adding the "#ifdef", I think, readability of 8250_pci.c goes down. Thanks, ----------------------------------------- Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html