Re: [Nios2-dev] [PATCH 0/5] tty: serial: Updates for altera_jtaguart driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011-02-18 at 09:06:15 +0100, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
> On Fri, Feb 18, 2011 at 12:45 AM, Tobias Klauser <tklauser@xxxxxxxxxx> wrote:
> > On 2011-02-18 at 08:29:58 +0100, Thomas Chou <thomas@xxxxxxxxxxxxx> wrote:
> >> On 02/18/2011 03:23 PM, Tobias Klauser wrote:
> >>> On 2011-02-17 at 23:15:04 +0100, Greg KH<greg@xxxxxxxxx>  wrote:
> >>>> On Thu, Feb 17, 2011 at 09:28:23PM +0100, Tobias Klauser wrote:
> >>>>> This patchset adds updates taken from the Nios2 Linux port (currently
> >>>>> out-of-tree) repository to the altera_jtaguart driver.
> >>>>>
> >>>>> And this time with the correct cover letter right away :-)
> >>>>>
> >>>>> Tobias Klauser (5):
> >>>>>    tty: serial: altera_jtaguart: Don't use plain integer as NULL pointer
> >>>>>    tty: serial: altera_jtaguart: Remove unused function
> >>>>>      early_altera_jtaguart_setup
> >>>>>    tty: serial: altera_jtaguart: Support getting mapbase and IRQ from
> >>>>>      resources
> >>>>>    tty: serial: altera_jtaguart: Fixup type usage of port flags
> >>>>>    tty: serial: altera_jtaguart: Add device tree support
> >>>>
> >>>> After this series, I get the following build error:
> >>>>       CC [M]  drivers/tty/serial/altera_jtaguart.o
> >>>>       drivers/tty/serial/altera_jtaguart.c:485:3: error: unknown field ???of_match_table??? specified in initializer
> >>>
> >>> Strange, I didn't get that one when compile testing against linux-next
> >>> on x86_64. Though it seems I didn't correctly test it on nios2 and I got
> >>> a compile error about a missing semicolon in the definition of
> >>> altera_jtaguart_match there.
> >>
> >> It might be that the of_match_table patch is available in Grant's branch
> >> only, which is for v3.6.39. Maybe you can ask Grant to take this patch
> >> 5/5.
> >
> > That explains it, thanks Thomas.
> >
> > Greg, care to take only patches 1/5 to 4/5 for now? I'll resubmit 5/5
> > for the 2.6.39 merge window, unless Grant already wants to take this to
> > his tree.
> 
> I'm happy to take this patch if it doesn't depend on the first 4.
> Alternately Greg, you could merge commit c9e358dfc "driver-core:
> remove conditionals around devicetree pointers" from my
> devicetree/test branch on git://git.secretlab.ca/git/linux-2.6.  I
> won't be rebasing that commit and it is the first commit on top of
> 2.6.38-rc1.

The patch doesn't depend on the first 4, so you could take it if Greg
doesn't oppose.

Thanks
Tobias
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux