Hi! Jesper is on vacation but I find this patch ok. Acked-by: Mikael Starvik<Starvik@xxxxxxxx> /Mikael -----Original Message----- From: Claudio Scordino [mailto:claudio@xxxxxxxxxxxxxxx] Sent: den 30 augusti 2010 10:32 To: Jesper Nilsson Cc: Mikael Starvik; linux-cris-kernel; Alan Cox; Andrew Morton; Hinko Kocevar; Janez Cufer; Andy Whitcroft; Linux Kernel; dev-etrax; linux-serial@xxxxxxxxxxxxxxx Subject: Re: [PATCH] CRIS RS485: Check SER_RS485_RTS_BEFORE_SEND before delaying. Claudio Scordino ha scritto: > Hi Jesper, > > the following patch fixes the usage of the delay in RS485 mode > on the Cris architecture. > > Very recently, the RS485 interface has been fixed by adding two further > fields (see commit 1b6331848b69d1ed165a6bdc75c4046d68767563). > > This patch checks the value of the flag SER_RS485_RTS_BEFORE_SEND before > delaying. Hi all, so far I didn't receive any acknowledgement about this patch. As I said, recently (see commit 1b6331848b69d1ed165a6bdc75c4046d68767563) the Linux RS485 interface has been fixed by adding two missing fields. With the "new" interface, you have to check the SER_RS485_RTS_BEFORE_SEND flag before using the delay_rts_before_send field. The Atmel serial driver has been already fixed (with commit 1b6331848b69d1ed165a6bdc75c4046d68767563 itself). This patch fixes the usage of the interface in the Cris driver too. Best regards, Claudio -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
