Hi, On Fri, Mar 19, 2010 at 6:58 PM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: > > On a quick parse, it seems mostly okay. I haven't dug into the driver > execution flow though. A few minor comments below. > thank you very much for the review. I'm waiting a bit for other people to comment and then prepare another patch. >> + resume_work); > > container_of is used a lot. Maybe consider a follow-on patch to > create a to_max3100_port() static inline. > ack >> +static irqreturn_t max3100_ist(int irq, void *dev_id) > > 'ist'? > interrupt service thread (compared to isr, interrupt service routine, for the code executed in hard interrupt context). I know it's windozece-speak and so *very lame*. Any suggestion for a better name is welcome! -- Christian Pellegrin, see http://www.evolware.org/chri/ "Real Programmers don't play tennis, or any other sport which requires you to change clothes. Mountain climbing is OK, and Real Programmers wear their climbing boots to work in case a mountain should suddenly spring up in the middle of the computer room." -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
