> -----Original Message----- > From: Peter Korsgaard [mailto:jacmet@xxxxxxxxx] On Behalf Of Peter Korsgaard > Sent: Thursday, January 21, 2010 1:26 AM > To: John Linn > Cc: linux-serial@xxxxxxxxxxxxxxx; grant.likely@xxxxxxxxxxxx; michal.simek@xxxxxxxxxxxxx; > john.williams@xxxxxxxxxxxxx > Subject: Re: [PATCH] [V2] uartlite: move from byte accesses to word accesses > > >>>>> "John" == John Linn <john.linn@xxxxxxxxxx> writes: > > John> Byte accesses for I/O devices in Xilinx IP are going to be less > John> desired in the future such that the driver is being changed to > John> use 32 bit accesses. > > John> This change facilitates using the uartlite IP over a PCIe bus > John> which only allows 32 bit accesses. > > John> Signed-off-by: John Linn <john.linn@xxxxxxxxxx> > John> --- > John> drivers/serial/uartlite.c | 36 ++++++++++++++++++------------------ > John> 1 files changed, 18 insertions(+), 18 deletions(-) > > John> diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c > John> index 377f271..9f83949 100644 > John> --- a/drivers/serial/uartlite.c > John> +++ b/drivers/serial/uartlite.c > John> @@ -86,7 +86,7 @@ static int ulite_receive(struct uart_port *port, int stat) > John> /* stats */ > John> if (stat & ULITE_STATUS_RXVALID) { > port-> icount.rx++; > John> - ch = readb(port->membase + ULITE_RX); > John> + ch = (u8)in_be32(port->membase + ULITE_RX); > > > I don't believe all those (u8) casts are needed (and they could > potentially mask away other problems in the future). > I'll send out a V3 for the patch. Sorry I dropped the ball and didn't get this taken care of. Thanks, John > Other than that, > > Acked-by: Peter Korsgaard <jacmet@xxxxxxxxxx> > > -- > Bye, Peter Korsgaard This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
