Re: [RESEND PATCH 2/2] serial: Add driver for the Altera UART

[Dan Carpenter <error27@xxxxxxxxx>]

A couple smatch complaints.

drivers/serial/altera_jtaguart.c
   380          if (co->index >= 0 && co->index <= ALTERA_JTAGUART_MAXPORTS)
   381                  co->index = 0;
   382          port = &altera_jtaguart_ports[co->index].port;

This test seems backward.  co->index == -1 would be a buffer underflow.

drivers/serial/altera_uart.c
   455          if ((co->index >= 0)
   456              && (co->index <= CONFIG_SERIAL_ALTERA_UART_MAXPORTS))
   457                  co->index = 0;
   458          port = &altera_uart_ports[co->index].port;

Same here.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html