Re: [PATCH 2/2] Add DMA support for the sh-sci.c serial driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 19, 2010 at 3:26 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> On Fri, 19 Feb 2010, Govindraj wrote:
>
>> > +       chan = dma_request_channel(mask, filter, param);
>> > +       dev_dbg(port->dev, "%s: RX: got channel %p\n", __func__, chan);
>>
>>
>> If dma channel allocation fails how this scenario will be handled,
>> There is an possibility of dma_request_channel returning -EBUSY,
>
> Really? How? I thought it could only return a pointer to a channel or a
> NULL? And if it fails, i.e., chan == NULL, the whole code just stays
> inactive and the driver falls back to normal PIO.

Sorry I missed this part:

if (s->chan_tx) {

if (s->chan_rx) {


> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
>

---
Regards,
Govindraj.R
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux