From: Márton Németh <nm127@xxxxxxxxxxx> The id_table field of the struct dio_driver is constant in <linux/dio.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by: Márton Németh <nm127@xxxxxxxxxxx> Cc: Julia Lawall <julia@xxxxxxx> Cc: cocci@xxxxxxx --- diff -u -p a/drivers/serial/8250_hp300.c b/drivers/serial/8250_hp300.c --- a/drivers/serial/8250_hp300.c 2009-12-03 04:51:21.000000000 +0100 +++ b/drivers/serial/8250_hp300.c 2010-01-08 18:52:23.000000000 +0100 @@ -39,7 +39,7 @@ static int __devinit hpdca_init_one(stru const struct dio_device_id *ent); static void __devexit hpdca_remove_one(struct dio_dev *d); -static struct dio_device_id hpdca_dio_tbl[] = { +static const struct dio_device_id hpdca_dio_tbl[] = { { DIO_ID_DCA0 }, { DIO_ID_DCA0REM }, { DIO_ID_DCA1 }, -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
