>-----Original Message----- >From: Mike Frysinger [mailto:vapier.adi@xxxxxxxxx] >Sent: Wednesday, June 03, 2009 4:04 PM >To: Alan Cox >Cc: Mike Frysinger; linux-serial@xxxxxxxxxxxxxxx; >linux-kernel@xxxxxxxxxxxxxxx; >uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx; Cai, Cliff; Bryan Wu >Subject: Re: [PATCH 04/11] Blackfin SPORT UART: fix overrun errors > >On Tue, Jun 2, 2009 at 05:00, Alan Cox wrote: >> On Tue, 2 Jun 2009 03:11:33 -0400 Mike Frysinger wrote: >>> From: Cliff Cai <cliff.cai@xxxxxxxxxx> >>> >>> Push the ty_flip_buffer_push() call from the IRQ handler to a timer >>> so as to improve performance and decrease likelihood of overruns. >> >> This should have no effect on a modern kernel. > >well, we wouldnt be making changes if we werent seeing data >overruns today > >> There is 64K of queueing between you and the ldisc nowdays. > >i dont think that really matters ... we do too much work in >the interrupt and so we miss new data > >> Furthermore unless you set tty->low_latency the kernel already >> basically does this aggregation for you as the buffer push queues >> stuff for the ldisc to wake up and process. > >i guess we could try setting the low_latency bool instead and >see if that fixes things -mike > The overrrun problem doesn't exist even without my patch now,so I will drop it. Thanks Cliff -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
