Re: Support for Meilhaus serial boards - patch (kernel 2.6.28)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 19 January 2009 16:10:32 Krzysztof Gantzke wrote:
> Dear Linux-serial team
> Meilhaus (PCI ID: 0x1402) ME90xx, ME91xx and ME93xx support added.
> The are RS232 and RS422/485 PCI serial boards.
> This patch was tested on x86 and x86_64 machines.
>
> Could you added this to main tree, please.

NAK. You should not add an ioctl to revert to RS232 mode but check 
serial_rs485.flags in TIOCSRS485. Enable RS485 when SER_RS485_ENABLED is set, 
disable it otherwise.

You should also probably base your patch to 8250.c on top of Matthias Fuchs' 
patch ('[PATCH V3] serial: Add ioctl to enable auto rs485 mode with some Exar 
UARTs').

Best regards,

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux