Atsushi Nemoto wrote: > > @@ -805,6 +805,9 @@ static int atmel_startup(struct uart_por > > */ > > UART_PUT_IDR(port, -1); > > > > + atmel_port->irq_status_prev = UART_GET_CSR(port); > > + atmel_port->irq_status = atmel_port->irq_status_prev; > > + > > /* > > * Allocate the IRQ > > */ > > Looks correct for me too. Then, what is preffered final fix? > > Put irq_status initialization into my patch, or replace with Itai's > patch? These patch put initialization in another place. Any comments > for preferred place to fix? I don't think it matters as long as it happens before the interrupts are enabled. But it's probably enough to do it once ;-) So the easiest solution is probably to drop your patch (atmel_serial-might-lose-modem-status-change.patch) and keep Itai's patch (atmel_serial-might-lose-modem-status-change-fix.patch). Andrew, if it makes things easier, feel free to drop both patches and I'll send you a new one. Haavard -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
